Remove BLS signatures aggregate #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K1li4nL
force-pushed
the
clean-up-bls
branch
3 times, most recently
from
0b262c6
to
fbbb53b
Compare
pierluca
reviewed
Sep 1, 2024
There was a problem hiding this comment.
Overalls LGTM, but this could benefit from @AnomalRoil 's review.
|
Turning this back into draft, I didn't properly ran the benchmarks... It seems that our bdn implementation assumes kyber.Scalar to be mod.Int, making it incompatible to use with circl_bls12381 |
AnomalRoil
reviewed
Sep 6, 2024
K1li4nL
force-pushed
the
clean-up-bls
branch
from
9b67b52
to
4092ac2
Compare
AnomalRoil
requested changes
Sep 10, 2024
K1li4nL
force-pushed
the
clean-up-bls
branch
from
4092ac2
to
071ab17
Compare
K1li4nL
force-pushed
the
clean-up-bls
branch
from
071ab17
to
bd676f6
Compare
|
AnomalRoil
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the BLS signature aggregate scheme is vulnerable to rogue public-key attack, this pr removes the "aggregate" part of the code and use BDN where BLS aggregates were used.